Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(dev-deps): update http-proxy-middleware from v2.0.6 to v3.0.0 #769

Merged
merged 1 commit into from
May 29, 2024
Merged

build(dev-deps): update http-proxy-middleware from v2.0.6 to v3.0.0 #769

merged 1 commit into from
May 29, 2024

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented May 28, 2024 •
edited
Loading

Resolves #768.

Updates dev dependency http-proxy-middleware from v2.0.6 to v3.0.0.
See the migration guide for more information: https://github.com/chimurai/http-proxy-middleware/blob/master/MIGRATION.md

How to test

  • checkout branch
  • run npm install
  • run npm run dev:start and/or npm run start
  • verify everything is running properly as before (e.g. create/import a wallet, attempt collaborative transaction, etc.)

@theborakompanioni theborakompanioni added dependencies Pull requests that update a dependency file devtools Improvements in tooling labels May 28, 2024
@theborakompanioni theborakompanioni self-assigned this May 28, 2024
@theborakompanioni theborakompanioni mentioned this pull request May 28, 2024
Closed
@theborakompanioni theborakompanioni marked this pull request as ready for review May 28, 2024 13:02
httpiga
httpiga approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@httpiga httpiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@theborakompanioni
Copy link
Collaborator Author

theborakompanioni commented May 29, 2024 •
edited
Loading

🙏

🙏

I assume it works as expected? : )
Just waiting for one more approval before merging. Thank you so much @httpiga

barrytra
barrytra approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@barrytra barrytra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! It works as expected

@theborakompanioni theborakompanioni merged commit 407098d into master May 29, 2024
3 checks passed
@theborakompanioni theborakompanioni deleted the fix/768 branch May 29, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barrytra barrytra barrytra approved these changes

@httpiga httpiga httpiga approved these changes

@0xSaksham 0xSaksham Awaiting requested review from 0xSaksham

@amitx13 amitx13 Awaiting requested review from amitx13

Assignees

@theborakompanioni theborakompanioni

Labels
dependencies Pull requests that update a dependency file devtools Improvements in tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeprecationWarning: 'onAfterSetupMiddleware' option is deprecated.
3 participants
@theborakompanioni @httpiga @barrytra