Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add global env variable substitution #227

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

Envek
Copy link
Contributor

@Envek Envek commented Mar 6, 2024

Re-add behavior that was first introduced in #54 and then removed in #58.

This behavior is present in Ruby dotenv (see spec/dotenv/parser_spec.rb#L66-L69)

This pull request is basically a rebase of #72 on top of current main branch (with parser rewritten).

See #74 for discussion.

Closes #72
Closes #74
Closes #88
Closes #102
Closes #103
Closes #135
Closes #149

Co-authored-by: Stanislau Arsoba <sarsoba@klika-tech.com>
Envek added a commit to DarthSim/overmind that referenced this pull request Mar 6, 2024
Fixes #172

Use another fork to keep up-to-date fix for #59
(waiting for upstream pull request joho/godotenv#227 to be merged)
Envek added a commit to DarthSim/overmind that referenced this pull request Mar 26, 2024
Fixes #177

See golang/go#44840 for details

Revert to original godotenv after joho/godotenv#227 merged to upstream
@joho joho merged commit a7f6c4c into joho:main Oct 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants