Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Conversation

johnnolan
Copy link
Owner

Description

Replace deprecated Roll with Rolls

Fixes #626

@github-actions
Copy link

Unit Test Results

    1 files  ±0    20 suites  ±0   5s ⏱️ -2s
133 tests ±0  133 ✔️ ±0  0 💤 ±0  0 ±0 
137 runs  ±0  137 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit dd11205. ± Comparison against base commit 1411291.

@github-actions
Copy link

Coverage report for commit: dd11205
File: coverage/clover.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ██░░░░░░░░░░░░░░░░░░░░░ │  4.5%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ ████░░░░░░░░░░░░░░░░░░░ │  9.1%
  90% │ ███████████░░░░░░░░░░░░ │ 27.3%
 100% │ ███████████████████████ │ 59.1%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 89.99% | Methods: 91.44% | Branches: 76.17%
FilesLinesMethodsBranches
scripts
   CampaignRenderer.ts91.25%96.30%81.25%
   CampaignStat.ts90.80%87.50%93.33%
   Chat.ts100.00%100.00%100.00%
   CombatFlag.ts100.00%100.00%100.00%
   EncounterRenderer.ts77.33%100.00%62.86%
   Handlers.ts81.67%66.67%70.97%
   SetupHooks.ts---
   StatManager.ts89.47%100.00%33.33%
   enums.ts100.00%100.00%100.00%
scripts/Helpers
   Dates.ts100.00%100.00%100.00%
   Gamemaster.ts100.00%100.00%100.00%
   Logger.ts100.00%100.00%100.00%
   Trans.ts100.00%100.00%100.00%
scripts/parsers
   DND5e.ts100.00%100.00%100.00%
   MidiQol.ts100.00%100.00%88.24%
   PF2e.ts100.00%100.00%58.82%
   ReadySetRoll.ts94.44%100.00%57.14%
scripts/stats
   DND5eStat.ts100.00%100.00%100.00%
   MidiQolStat.ts100.00%100.00%100.00%
   PF2eStat.ts100.00%100.00%100.00%
   ReadySetRollStat.ts92.00%100.00%66.67%
   Stat.ts94.02%90.41%67.62%

🤖 comment via lucassabreu/comment-coverage-clover

@ghost
Copy link

ghost commented Oct 21, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@johnnolan johnnolan merged commit e4fc1e1 into main Oct 21, 2023
@johnnolan johnnolan deleted the 626-bug-setuphookspf2ets-uses-deprecated-chatmessagepf2eroll-instead-of-chatmessagepf2erolls branch October 21, 2023 10:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] SetupHooksPF2e.ts uses deprecated chatMessagePF2e.roll instead of chatMessagePF2e.rolls
1 participant