Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

#minor Fix for non midi criticals are tracked in combat #399

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

johnnolan
Copy link
Owner

Description

This allows for weapons with custom critical thresholds

Fixes #282

This allows for weapons with custom critical thresholds

Fixes #282
@github-actions
Copy link

Unit Test Results

    1 files  ±0    16 suites  ±0   5s ⏱️ -2s
117 tests ±0  117 ✔️ ±0  0 💤 ±0  0 ±0 
120 runs  ±0  120 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit cd4f7d3. ± Comparison against base commit 1fc29d6.

@github-actions
Copy link

Coverage report for commit: cd4f7d3
File: coverage/clover.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ ██░░░░░░░░░░░░░░░░░░░░░ │  5.9%
  90% │ ████████░░░░░░░░░░░░░░░ │ 23.5%
 100% │ ███████████████████████ │ 70.6%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 92.50% | Methods: 90.67% | Branchs: 79.64%
FilesLinesMethodsBranchs
   CampaignRenderer.ts90.91%96.15%78.57%
   CampaignStat.ts97.47%100.00%92.31%
   Chat.ts100.00%100.00%-
   CombatFlag.ts100.00%100.00%100.00%
   DND5e.ts100.00%100.00%100.00%
   DND5eStat.ts100.00%100.00%100.00%
   Dates.ts100.00%100.00%-
   EncounterRenderer.ts77.33%100.00%62.86%
   Gamemaster.ts100.00%100.00%100.00%
   Handlers.ts94.79%80.00%86.36%
   Logger.ts100.00%100.00%100.00%
   MidiQol.ts100.00%100.00%93.33%
   MidiQolStat.ts100.00%100.00%100.00%
   Stat.ts89.73%80.36%60.27%
   StatManager.ts89.47%100.00%33.33%
   Trans.ts100.00%100.00%-
   enums.ts100.00%100.00%100.00%

🤖 comment via lucassabreu/comment-coverage-clover

@johnnolan johnnolan merged commit ccdfa75 into main Nov 22, 2022
@johnnolan johnnolan deleted the critical-threshold branch November 22, 2022 21:11
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a way to track non-natural crits? IE: 19's that are "crits" due to a feat
1 participant