Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detection for Sugar #195

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Add detection for Sugar #195

merged 3 commits into from
Apr 12, 2022

Conversation

connorjclark
Copy link
Collaborator

jridgewell
jridgewell reviewed Feb 1, 2022
View reviewed changes
library/libraries.js Outdated
url: 'https://sugarjs.com',
npm: 'sugar',
test: function (win) {
if (!win.Sugar) return false;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versions up to 1.3.9 don't seem to include a Sugar global, but instead patch directly onto prototypes. Eg, Array.SugarMethods would exist.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@housseindjirdeh housseindjirdeh merged commit fa8e3d1 into johnmichel:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell left review comments

@housseindjirdeh housseindjirdeh housseindjirdeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjclark @jridgewell @housseindjirdeh