Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved file-not-found handling #1508

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Improved file-not-found handling #1508

merged 1 commit into from
Feb 26, 2024

Conversation

johnkerl
Copy link
Owner

For some file formats, file-not-found errors were appearing as an ugly panic with stack trace.

Before:

$ mlr --tsv cat nonesuch
fatal error: all goroutines are asleep - deadlock!

goroutine 1 [select]:
github.com/johnkerl/miller/pkg/stream.Stream({0x1400010bbb0, 0x1, 0x1}, 0x140001ea540, {0x14000154f00, 0x2, 0x2}, {0x1010dc070?, 0x1400011e008}, 0x1)
... more lines ...

After:

$ mlr --tsv cat nonesuch
mlr: open nonesuch: no such file or directory.

@johnkerl johnkerl force-pushed the kerl/nonesuch-no-panic branch from e5485a8 to 0716c9e Compare February 26, 2024 05:06
@johnkerl johnkerl merged commit aff4b9f into main Feb 26, 2024
6 checks passed
@johnkerl johnkerl deleted the kerl/nonesuch-no-panic branch February 26, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant