Arnold camera projection #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids exceptions in ScenePathPlugValueWidget, which may not always be able to find a suitable ScenePlug to show.
johnhaddon
force-pushed
the
arnoldCameraProjection
branch
from
062afd9
to
0d80c8c
Compare
We do this by accepting StringData parameters with the path to a node, and then resolving that to a `NODE *` at the very last minute in `ArnoldRenderer::render()`. This is robust to the targeted node being deleted or replaced. In an ideal world, Arnold's `camera_projection` shader would just have a string parameter instead, like its `toon.lights` parameter. We do the resolution to `NODE *` in our ShaderCache, which means there are currently a couple of caveats : - Shaders inside procedurals are not supported, because ProceduralRenderer uses its own ShaderCache which is destroyed after expansion. We do want procedurals to share the main caches in future anyway, at which point this would "just work". - Light shaders are not supported, because they're not stored in the cache because lights need unique ownership. Hopefully this isn't a likely use case. One potential solution might be to have ArnoldLight pull from the ShaderCache, but passing an argument that always uniquefies the hash.
This is just a case of setting the `gaffer.plugType` to "StringPlug" and letting the recently added `NodeParameter` mechanism do the rest in `ArnoldRenderer`. Also added a nice camera browser using ScenePathPlugValueWidget. I was unsure what to do for this in ArnoldShaderUI, as the "camera" value for "widget" isn't part of the OSL standard. The other option would have been to support three new Gaffer-specific metadata entries for `gaffer.plugValueWidget.type`, `scenePathPlugValueWidget.setNames` and `scenePathPlugValueWidget:setsLabel`. But that seemed quite faffy when we don't have any other use cases for them at present, and "camera" seems like something that could reasonably be supported by other DCCs.
johnhaddon
force-pushed
the
arnoldCameraProjection
branch
from
0d80c8c
to
a22dffc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.