Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repository Conventions fail to get primary key property from base class #597

Closed
johelvisguzman opened this issue Mar 25, 2020 · 0 comments · Fixed by #598
Closed

Repository Conventions fail to get primary key property from base class #597

johelvisguzman opened this issue Mar 25, 2020 · 0 comments · Fixed by #598
Labels
bug Something isn't working
Milestone
3.0.0

Comments

@johelvisguzman
Copy link
Owner

The PrimaryKeyConventionHelper class seems to be using the GetDeclaredProperty method, which gets the property in the current type; we should be using GetProperty instead. The only problem is that this is not available for netstandard 1.3
@johelvisguzman johelvisguzman added the bug Something isn't working label Mar 25, 2020
@johelvisguzman johelvisguzman added this to the 3.0.0 milestone Mar 25, 2020
johelvisguzman added a commit that referenced this issue Mar 25, 2020
@johelvisguzman
(GH-597) Allowed the primary key conventions helper to get the key fr…
0cd7ae9 
…om a base class
@johelvisguzman johelvisguzman mentioned this issue Mar 25, 2020
Merged
johelvisguzman added a commit that referenced this issue Mar 25, 2020
@johelvisguzman
Merge pull request #598 from johelvisguzman/GH-597
9480a4a 
(GH-597) Allowed the primary key conventions helper to get the key from a base class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.0.0
1 participant
@johelvisguzman