Updates for force delete and prefix and delim bug

[casibbald]

1. Adding force delete

• This functionality is critical for testing against MinIO, which is heavily used in corporate environments, and the API some enterprise-level storage systems utilise.

3. Fixes for prefix and delim bug

[codecov]

Codecov Report

Attention: Patch coverage is 11.86441% with 52 lines in your changes missing coverage. Please review.

Project coverage is 64.95%. Comparing base (0da3aa9) to head (ead58cb).
Report is 10 commits behind head on master.

Files with missing lines	Patch %	Lines
backend/s3afero/single.go	0.00%	20 Missing ⚠️
backend/s3afero/multi.go	0.00%	15 Missing ⚠️
gofakes3.go	33.33%	7 Missing and 3 partials ⚠️
backend/s3mem/backend.go	0.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   66.15%   64.95%   -1.20%     
==========================================
  Files          28       28              
  Lines        2712     2768      +56     
==========================================
+ Hits         1794     1798       +4     
- Misses        650      699      +49     
- Partials      268      271       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[johannesboyne]

Hi @casibbald, if you want to re-open the PR, I am more than happy to review and merge the changes. Looks like a meaningful improvement.

[casibbald]

Hi Johannes, It's likely a reduced version of the PR may come through with just the prefix/delim bug fix.
We will check if Weave-gitops still needs the force delete of buckets, if it does we will put that in.
I cancelled the PR we felt that it might be two PR's

[johannesboyne]

Great to hear that! Will take a look at it shortly!

[johannesboyne]

Everything looks good! Thanks a lot for the contribution!

One could add to https://github.com/johannesboyne/gofakes3/blob/master/gofakes3_test.go#L486C1-L512C2 the additional check

// pseudo code - not fully integrated/tested
t.Run("forece-delete-does-not-fail-if-not-empty", func(t *testing.T) {
	ts := newTestServer(t, withoutInitialBuckets())
	defer ts.Close()
	svc := ts.s3Client()

	ts.backendCreateBucket("test")
	ts.backendPutString("test", "test", nil, "test")
	ts.OKAll(svc.ForceDeleteBucket(&s3.DeleteBucketInput{
		Bucket: aws.String("test"),
	}))
})

[johannesboyne]

Awesome work!

[sonarqubecloud]

Quality Gate failed

Failed conditions
6.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

[casibbald]

I think I have noticed some error/stdout messages that 'read wrong'. The code is good. will update over the weekend
Please do not merge before.

[johannesboyne]

Hi @casibbald sorry, I did not read your last comment properly! But let's just roll forward and integrate the changed error/stdout messages.