Feature request : support Disconnect event for room matched by "next?" #479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, i noticed that a peer matched by a
next?
never receives disconnected event.From what I understand in the codebase, this happens because the room is purged once all peers have joined (likely to make space for the next clients)., thus making disconnected peers never able to notify others in that room.
This PR addresses the issue by saving the full list of room peers before purging it, allowing those events to be sent later.
This may not be the best way to handle this, let me know if any changes are needed!