Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request : support Disconnect event for room matched by "next?" #479

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fcornaire
Copy link

Hello, i noticed that a peer matched by a next? never receives disconnected event.
From what I understand in the codebase, this happens because the room is purged once all peers have joined (likely to make space for the next clients)., thus making disconnected peers never able to notify others in that room.

This PR addresses the issue by saving the full list of room peers before purging it, allowing those events to be sent later.

This may not be the best way to handle this, let me know if any changes are needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant