Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run clippy with signaling feature enabled #445

Merged
merged 3 commits into from
Mar 31, 2024
Merged

ci: Run clippy with signaling feature enabled #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc7ab02
ci: Run clippy with signaling feature enabled
johanhelsing Mar 31, 2024
a24b51e
chore: Fix new dead_code warning in signaling module
johanhelsing Mar 31, 2024
3ae4f6e
Fix clippy warning
johanhelsing Mar 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/code.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:
uses: Swatinem/rust-cache@v2.7.3

- name: Run cargo clippy
run: cargo clippy --all-targets -- -D warnings
run: cargo clippy --features signaling --all-targets -- -D warnings

lint-wasm:
name: Clippy wasm
Expand Down
3 changes: 2 additions & 1 deletion bevy_matchbox/src/signaling.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ use std::net::SocketAddr;
/// }
/// ```
#[derive(Debug, Resource)]
#[allow(dead_code)] // we take ownership of the task to not drop it
pub struct MatchboxServer(Task<Result<(), Error>>);

impl<Topology, Cb, S> From<SignalingServerBuilder<Topology, Cb, S>> for MatchboxServer
Expand Down Expand Up @@ -175,7 +176,7 @@ mod tests {
)
.into();

commands.insert_resource(MatchboxServer::from(server));
commands.insert_resource(server);
}

#[test]
Expand Down
Loading