fix: [bevy_ggrs example] add tonemapping_luts bevy feature #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
|
Thanks. We've had quite a few similar issues... wondering if perhaps it's less of a hassle to simply depend on bevy with default-features, even if it produces huge binaries and takes a while to build. Anyway, not for this PR. /rant Thanks for the fix! |
johanhelsing
approved these changes
Feb 18, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #398
With the fix
Without the fix
Important caveat
This fix is only for WASM. The native compilation is still broken as per #417
Extra context
Seems that this was forgotten, because the dependency was added for bevy_matchbox
https://github.com/AgustinRamiroDiaz/matchbox/blob/a70b27a5291cf0427e4312c75d6529625fe3e970/bevy_matchbox/Cargo.toml#L50