You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
error: field `1` is never read
--> bevy_matchbox/src/socket.rs:73:67
|
73 | pub struct MatchboxSocket<C: BuildablePlurality>(WebRtcSocket<C>, Box<dyn Debug + Send + Sync>);
| -------------- field in this struct ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `MatchboxSocket` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
73 | pub struct MatchboxSocket<C: BuildablePlurality>(WebRtcSocket<C>, ());
|
It looks like it's there to just make sure we don't drop the task handle. I'm not sure what the practical difference is between detaching and keeping the handle in the socket, though... Maybe @garryod remembers?
Perhaps we should just add #[allow(dead_code)] for it?
The text was updated successfully, but these errors were encountered:
After rust 1.77, we know get clippy warnings in ci:
https://github.com/johanhelsing/matchbox/actions/runs/8407545605/job/23023258077?pr=436
To repro:
Did not happen with rust 1.76
The field was added in 4295f6d by @garryod.
It looks like it's there to just make sure we don't drop the task handle. I'm not sure what the practical difference is between detaching and keeping the handle in the socket, though... Maybe @garryod remembers?
Perhaps we should just add
#[allow(dead_code)]
for it?The text was updated successfully, but these errors were encountered: