Add custom headers support to CONNECT frame #65
Conversation
|
The ABI compat check broke to warn us of non-backwards-compat change on the binary level. Because we're changing the ABI here (adding a param even with a default), we need to regenerate (and commit) the ABI description file. Please do that by running |
|
Also, please add a corresponding test to check that custom headers are actually sent when provided |
| @@ -40,10 +40,10 @@ class StompClient( | |||
| * @throws ConnectionTimeout if this method takes longer than the configured | |||
| * [timeout][StompConfig.connectionTimeoutMillis] (as a whole for both WS connect and STOMP connect) | |||
| */ | |||
| suspend fun connect(url: String, login: String? = null, passcode: String? = null): StompSession { | |||
| suspend fun connect(url: String, login: String? = null, passcode: String? = null, customHeaders: Map<String, String> = emptyMap()): StompSession { | |||
There was a problem hiding this comment.
Now that I think of it, I might add custom headers for the websocket connection too later.
To avoid a backwards-incompatible change in the future, could you please rename this param customStompConnectHeaders.
Also please add a relevant sentence in the doc to explain what the param does.
There was a problem hiding this comment.
Thank you for your answer.
Learning every day 👍
There was a problem hiding this comment.
Well thank you for the contribution! 😄
|
Great, thank you for merging this and for your work. |
@Mostrapotski I just added one more test, and I will release immediately when the build is proved to succeed on all platforms. |
No description provided.