Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring websocket adapter deadlocks on close() #72

Closed
2 of 7 tasks
joffrey-bion opened this issue Sep 26, 2020 · 0 comments
Closed
2 of 7 tasks

Spring websocket adapter deadlocks on close() #72

joffrey-bion opened this issue Sep 26, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@joffrey-bion
Copy link
Owner

Describe the bug

When no consumer is listening to the incomingFrames channel, the close() suspends forever.

Reproduction and additional details

val session = SpringDefaultWebSocketClient.connect(url)
session.close()

Context

Kotlin version: 1.4.0
Krossbow version: 0.42.0
Kotlin target: JVM

  • krossbow-stomp-core
  • krossbow-stomp-jackson
  • krossbow-stomp-kxserialization
  • krossbow-websocket-core
  • krossbow-websocket-sockjs
  • krossbow-websocket-spring
  • krossbow-websocket-okhttp
@joffrey-bion joffrey-bion added the bug Something isn't working label Sep 26, 2020
joffrey-bion pushed a commit that referenced this issue Sep 26, 2020
Fix spring websocket adapter's deadlock
fc61d17 
Related:
#72
joffrey-bion pushed a commit that referenced this issue Sep 27, 2020
Fix spring websocket adapter's deadlock
30d54af 
Resolves:
#72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joffrey-bion