-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation of gradle Java 11 project failed #288
Comments
Thanks for the report, I made a mistake in the CI config and I'm now publishing with byte code level 17. This was unintentional. I'll release a patch for java 11 compatibility |
It turns out there are some issues with the new macos runners that are only fixed with Kotlin 1.8. I will first migrate to Kotlin 1.8 and then will be able to move forward with the JDK 11 CI setup, sorry. The Gradle error for reference:
It happens on GitHub Actions macos-12 runner. Should be solved in Kotlin 1.8, see https://youtrack.jetbrains.com/issue/KT-54814 |
Ok, thank you for your reply. I will upgrade kotlin to 1.8 |
Sorry if I was unclear. I meant the issues on GA runner prevent me from releasing a patch for krossbow. So I will upgrade Krossbow to Kotlin 1.8 in order to fix the build and be able to release again. I didn't mean you should upgrade on your side to fix the java 11 issue. That being said, the next version of krossbow with jdk11 support will indeed be using kotlin 1.8, so you might need to upgrade on your side when upgrading krossbow. |
Thank you for your reminder. I understand. Now I temporarily remove this dependency to solve the problem, and add it again after the dependency version is upgraded |
@mdddj Actually, I double checked, and despite the CI using JDK 17 to compile the classes, the default Kotlin target JVM bytecode was still Java 8. I just checked the class files from
I released Krossbow version 5.0.0 which compiled all artifacts on CI using JDK 11, but the result is the same: java 8 compatible bytecode by default. I think your issue might be that you're using an old Gradle version that doesn't recognize the metadata properly. Could you please check the following:
Do you still have the error in either of those? I would assume you have the same error in 1) but the error is gone in 2) and 3). Is this correct? |
After I upgrade, there are no problems with the above three points |
After you upgrade what exactly? Some of the points are about not upgrading |
Describe the bug
Compilation failed in gradle configuration project
Reproduction and additional details
Context
my config file
The text was updated successfully, but these errors were encountered: