Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use triple-quoted raw strings in regexp constants #223

Merged
merged 1 commit into from
Sep 24, 2017
Merged

Use triple-quoted raw strings in regexp constants #223

merged 1 commit into from
Sep 24, 2017

Conversation

jwilk
Copy link
Contributor

@jwilk jwilk commented Dec 30, 2016

This reduces the number of needed escape sequences, and fixes Python 3.6 warnings:

grip/constants.py:32: DeprecationWarning: invalid escape sequence \(
grip/constants.py:35: DeprecationWarning: invalid escape sequence \(

The anomalous escape sequences were found using pydiatra.

This reduces the number of needed escape sequences, and fixes Python 3.6
warnings:

    grip/constants.py:32: DeprecationWarning: invalid escape sequence \(
    grip/constants.py:35: DeprecationWarning: invalid escape sequence \(
@joeyespo joeyespo merged commit 41b2509 into joeyespo:master Sep 24, 2017
@joeyespo
Copy link
Owner

Very nice! Looks like the r prefix is what fixed the deprecation warning. Using ''' is very nice. Much easier to read.

Thanks, @jwilk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants