Replace secondary face index with "pages" system. #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps the exact same behaviour in the default case, but allows for having more than two pages of faces.
WesleyAC
force-pushed
the
movement-pages
branch
from
1428cf3 to
4503075
Compare
|
Trying this on my watch and I'm not convinced it's the right system. I have some other ideas that I'm going to try out for making navigating through many faces easier, but I'm going to close this for now. Would be curious to hear thoughts from anyone who gives it a shot, though! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the exact same behaviour in the default case, but allows for having more than two pages of faces, useful for navigating a large number of faces.
The first commit implements this change.
The second commit adds a variable for configuring which faces are hidden, instead of hiding all but the first page of faces.
The third commit allows more configuration of mode long-press behaviour.
It's very possible that there's a nicer way to expose/configure this, I understand that this might be providing more knobs than people want. I'm happy to try to implement other ideas or write more thorough comments if that would help.