Change (cmd): Revert images to use CMD /bin/sh and /bin/bash
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting `CMD` values to `ansible` is mostly pointless as `ansible` is an executable rather than a shell. Parameters specified after the `docker run image:tag` command are ignored unless `ansible` is set as the images' `ENTRYPOINT`. Yet since `ansible-playbook` is most likely to be used in images, specifying `ansible` as the images' `ENTRYPOINT` would introduce a breaking-change in design of the images potentially reducing their usefulness by being too specific in design. Having a more generic design is preferred and allows administrators to also interact within container shell environments for administrating systems in combination with `ansible` binaries. This reverts commit 862bf05.
joeltimothyoh
force-pushed
the
change/cmd-revert-images-to-use-cmd--bin-sh-and--bin-bash
branch
from
9cdc0d6 to
e260558
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
CMDvalues toansibleis mostly pointless asansibleis an executable rather than a shell. Parameters specified after thedocker run image:tagcommand are ignored unlessansibleis set as the images'ENTRYPOINT. Yet sinceansible-playbookis most likely to be used in images, specifyingansibleas the images'ENTRYPOINTwould introduce a breaking-change in design of the images potentially reducing their usefulness by being too specific in design. Having a more generic design is preferred and allows administrators to also interact within container shell environments for administrating systems in combination withansiblebinaries.This reverts commit 862bf05.