Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error with some versions of node-0.9 #49

Merged
merged 1 commit into from
May 8, 2013

Conversation

zuazo
Copy link
Contributor

@zuazo zuazo commented May 8, 2013

node-java compilation fails with node versions between v0.9.4 and v0.9.12. Tested with binary donwloadable versions from the official site. Gives the following error:

make: Entering directory `~/forks/node-java/build'
  ACTION Verify Deps build/depsVerified
  CXX(target) Release/obj.target/nodejavabridge_bindings/src/java.o
../src/java.cpp: In function ‘_jobject* Java_node_NodeDynamicProxyClass_callJs(JNIEnv*, _jobject*, jlong, _jobject*, _jobjectArray*)’:
../src/java.cpp:740: error: invalid conversion from ‘void (*)(uv_work_t*)’ to ‘void (*)(uv_work_t*, int)’
../src/java.cpp:740: error: initializing argument 4 of ‘int uv_queue_work(uv_loop_t*, uv_work_t*, void (*)(uv_work_t*), void (*)(uv_work_t*, int))’
make: *** [Release/obj.target/nodejavabridge_bindings/src/java.o] Error 1
make: Leaving directory `~/forks/node-java/build'

This PR solves the problem. Tested to work with multiple node versions between v.0.6.0 and v.0.11.1.

Perhaps related with the issue #43.

joeferner added a commit that referenced this pull request May 8, 2013
Fix compilation error with some versions of node-0.9
@joeferner joeferner merged commit b8ab8d9 into joeferner:master May 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants