Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hg implementation #3

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Conversation

zegervdv
Copy link
Contributor

@zegervdv zegervdv commented Dec 5, 2022

As the title says, adds mercurial (hg) support.

I stubbed those extra attributes like i_crlf and attr as they don't seem to be used right now, and I'm not sure if and how to get that information from mercurial.

I need to set the config to vcs = 'hg' for this to work, but would it be an option to make it figure that out automatically?
I guess that could also be done in the on_attach function by using the client's root dir.

@joechrisellis
Copy link
Owner

Thanks so much for writing this. 🙏

I'll block some time out this weekend for a proper review and test. 👍

@joechrisellis
Copy link
Owner

@zegervdv apologies for the delay on this. Had a chance to check this out today and all seems to work great. Given that hg is less popular than Git, I'm happy to merge this in with the TODOs and shake out any bugs if/when they show up. Thanks for your work here!

@joechrisellis joechrisellis merged commit e474434 into joechrisellis:main Dec 28, 2022
@zegervdv
Copy link
Contributor Author

No apologies needed, it's your spare time :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants