Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cxclsx #152

Merged
merged 1 commit into from
Apr 27, 2023
Merged

cxclsx #152

merged 1 commit into from
Apr 27, 2023

Conversation

joe-bell
Copy link
Owner

@joe-bell joe-bell commented Apr 27, 2023

Description

I've been keen to keep cva dependency-free for as long as possible, but it's really hard to justify when clsx does such a better job than cx with zero change to bundle-size!

This PR:

  • Provides additional support for booleans and variadic strings (closes updated types & tests #122) within class or className props
  • Provides support for object syntax within class or className props

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the Style Guide.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@vercel
Copy link

vercel bot commented Apr 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 1:32pm
example-astro-with-tailwindcss ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 1:32pm
example-react-with-css-modules ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 1:32pm
example-react-with-tailwindcss ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 1:32pm
example-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 1:32pm
example-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 1:32pm

@joe-bell joe-bell marked this pull request as ready for review April 27, 2023 13:30
@joe-bell joe-bell merged commit ec25777 into main Apr 27, 2023
@joe-bell joe-bell deleted the feat/clsx branch April 27, 2023 13:42
sebald referenced this pull request in sebald/pattern-analyzer May 11, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [class-variance-authority](https://togithub.com/joe-bell/cva) |
[`0.5.2` ->
`0.6.0`](https://renovatebot.com/diffs/npm/class-variance-authority/0.5.2/0.6.0)
|
[![age](https://badges.renovateapi.com/packages/npm/class-variance-authority/0.6.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/class-variance-authority/0.6.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/class-variance-authority/0.6.0/compatibility-slim/0.5.2)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/class-variance-authority/0.6.0/confidence-slim/0.5.2)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>joe-bell/cva</summary>

### [`v0.6.0`](https://togithub.com/joe-bell/cva/releases/tag/v0.6.0)

[Compare
Source](https://togithub.com/joe-bell/cva/compare/v0.5.3...v0.6.0)

#### What's Changed

- `cx` → `clsx` by [@&#8203;joe-bell](https://togithub.com/joe-bell) in
[https://github.com/joe-bell/cva/pull/152](https://togithub.com/joe-bell/cva/pull/152)

**`cva` now uses `clsx` under-the-hood** to concatenate classes with
**no breaking changes** to the current experience and **no increase to
bundle-size**.

    The existing `cx` export still exists, but as an alias of `clsx`

    Bringing additional benefits of:

1. Provides additional support for booleans and variadic strings within
`class` or `className` props

        ```ts
const button = cva([true && "button-base", false && "not-rendered"]);
        // => 'button-base'

const buttonConsumer = button({ class: [true && "extra-class"] });
        // => 'button-base extra-class'
        ```

2. Provides support for [object](https://togithub.com/lukeed/clsx#usage)
syntax within `class` or `className` props

        ```ts
        const button = cva({ foo: true, bar: false });
        // => 'foo baz'
        ```

**Full Changelog**:
joe-bell/cva@v0.5.3...v0.6.0

### [`v0.5.3`](https://togithub.com/joe-bell/cva/releases/tag/v0.5.3)

[Compare
Source](https://togithub.com/joe-bell/cva/compare/v0.5.2...v0.5.3)

#### What's Changed

- fix: issue [#&#8203;147](https://togithub.com/joe-bell/cva/issues/147)
where map files are not present for esm files by
[@&#8203;pfried](https://togithub.com/pfried) in
[https://github.com/joe-bell/cva/pull/148](https://togithub.com/joe-bell/cva/pull/148)

    > Thank you [@&#8203;pfried](https://togithub.com/pfried)!

- fix: Added explicit undefined type to support
exactOptionalPropertyTypes option by
[@&#8203;totto2727](https://togithub.com/totto2727) in
[https://github.com/joe-bell/cva/pull/149](https://togithub.com/joe-bell/cva/pull/149)

> This has been a long standing issue for me and I'm **so** grateful to
[@&#8203;totto2727](https://togithub.com/totto2727) for making the fix

#### New Contributors

- [@&#8203;pfried](https://togithub.com/pfried) made their first
contribution in
[https://github.com/joe-bell/cva/pull/148](https://togithub.com/joe-bell/cva/pull/148)
- [@&#8203;totto2727](https://togithub.com/totto2727) made their first
contribution in
[https://github.com/joe-bell/cva/pull/149](https://togithub.com/joe-bell/cva/pull/149)

**Full Changelog**:
joe-bell/cva@v0.5.2...v0.5.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/sebald/pattern-analyzer).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42Ni4xIiwidXBkYXRlZEluVmVyIjoiMzUuNjYuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant