Take all configuration via an explicit ParseConfig object
#385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodal
force-pushed
the
push-tylvszzmxvkz
branch
4 times, most recently
from
3c25992 to
5885bb3
Compare
To be passed around to all parsers instead of a growing set of keyword arguments.
jodal
force-pushed
the
push-tylvszzmxvkz
branch
from
5885bb3 to
7d6d4e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 16 +1
Lines 1059 1076 +17
Branches 106 110 +4
=========================================
+ Hits 1059 1076 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jodal
changed the title
ParseConfig objectParseConfig object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the config object to all parsers instead of passing around a growing set of keyword arguments.
Breaking change