Rename {fnc1 => separator}_required and update GS1 datasets
#382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New AIs: - 03: MTO GTIN - 7041: UFRGT UNIT TYPE - 716: NHRN AIC - 7250: DOB - 7251: DOB TIME - 7252: BIO SEX - 7253: FAMILY NAME - 7254: GIVEN NAME - 7255: SUFFIX - 7256: FULL NAME - 7257: PERSON ADDR - 7258: BIRTH SEQUENCE - 7259: BABY - 8014: MUDI Other changes: - 8008: Pattern no longer accepts hour 24 in its timestamp - Quite a few `description` and `data_title` with minor changes
Breaking change
- 605 and 606 assigned to GS1 Uganda - 632 assigned to GS1 Rwanda
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1067 1067
Branches 106 106
=========================================
Hits 1067 1067 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the
GS1ApplicationIdentifier.fnc1_requiredfield toseparator_required. This is both more descriptive and matches GS1's new naming in their AI dataset.All three GS1 datasets are updated to the latest version.