Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always return ParseResult from biip.parse() #376

Merged
merged 1 commit into from
Mar 15, 2025
Merged

Conversation

jodal
Copy link
Owner

@jodal jodal commented Mar 15, 2025

This makes it a bit easier to use biip.parse() as you will no longer need to catch ParseError to handle all cases.

This isn't a breaking change unless you relied on parse() to raise when no parsing attempt succeeds.

Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (42f3fc1) to head (be91bd5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #376   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1082      1075    -7     
  Branches       107       106    -1     
=========================================
- Hits          1082      1075    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jodal jodal merged commit c1714ba into main Mar 15, 2025
14 checks passed
@jodal jodal deleted the always-parse-result branch March 15, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant