Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GS1CompanyPrefix support #172

Merged
merged 3 commits into from
Dec 18, 2022
Merged

Add GS1CompanyPrefix support #172

merged 3 commits into from
Dec 18, 2022

Conversation

jodal
Copy link
Owner

@jodal jodal commented Dec 18, 2022

This PR adds the initial parts of GS1 Company Prefix support:

  • A script to parse GS1's XML data set and build a trie data structure to look
    up the Company Prefix lengths.
  • Decompressing and loading of the Company Prefix trie on import of Biip.
  • A GS1CompanyPrefix class to extract the Company Prefix length from any value.

Part of #160

@jodal jodal self-assigned this Dec 18, 2022
@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (ed698a2) compared to base (76ef365).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head ed698a2 differs from pull request most recent head 6f6c459. Consider uploading reports for the commit 6f6c459 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #172   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          886       911   +25     
  Branches       138       146    +8     
=========================================
+ Hits           886       911   +25     
Impacted Files Coverage Δ
src/biip/gs1/__init__.py 100.00% <100.00%> (ø)
src/biip/gs1/_prefixes.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jodal jodal force-pushed the jodal/gs1-company-prefix branch from 66e7c14 to c94d6e4 Compare December 18, 2022 22:40
@jodal jodal force-pushed the jodal/gs1-company-prefix branch from c94d6e4 to ed698a2 Compare December 18, 2022 22:41
@jodal jodal force-pushed the jodal/gs1-company-prefix branch from ed698a2 to 6f6c459 Compare December 18, 2022 22:43
@jodal jodal merged commit bb29536 into main Dec 18, 2022
@jodal jodal deleted the jodal/gs1-company-prefix branch December 18, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant