Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vector union, string and struct union support for Python #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jochenparm
Copy link
Owner

No description provided.

Copy link

@code-review-doctor code-review-doctor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to consider. View full project report here.

from flatbuffers.compat import import_numpy
np = import_numpy()

class Attacker(object):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class Attacker(object):
class Attacker:

Attacker inherits from object by default, so explicitly inheriting from object is redundant. Removing it keeps the code simpler. Explained here.

def End(builder):
return AttackerEnd(builder)

class AttackerT(object):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class AttackerT(object):
class AttackerT:

Similarly, Explicitly inheriting from object is redundant.

from flatbuffers.compat import import_numpy
np = import_numpy()

class BookReader(object):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class BookReader(object):
class BookReader:

BookReader inherits from object by default, so explicitly inheriting from object is redundant. Removing it keeps the code simpler. More info.

return builder.Offset()


class BookReaderT(object):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class BookReaderT(object):
class BookReaderT:

Same as above: Explicitly inheriting from object is redundant.


# namespace:

class Character(object):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class Character(object):
class Character:

Character inherits from object by default, so explicitly inheriting from object is redundant. Removing it keeps the code simpler. Read more.

def End(builder):
return HandFanEnd(builder)

class HandFanT(object):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class HandFanT(object):
class HandFanT:

Similarly, Explicitly inheriting from object is redundant.

from flatbuffers.compat import import_numpy
np = import_numpy()

class Movie(object):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class Movie(object):
class Movie:

Movie inherits from object by default, so explicitly inheriting from object is redundant. Removing it keeps the code simpler. Read more.

except:
pass

class MovieT(object):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class MovieT(object):
class MovieT:

Again, Explicitly inheriting from object is redundant.

from flatbuffers.compat import import_numpy
np = import_numpy()

class Rapunzel(object):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class Rapunzel(object):
class Rapunzel:

Rapunzel inherits from object by default, so explicitly inheriting from object is redundant. Removing it keeps the code simpler. Read more.

return builder.Offset()


class RapunzelT(object):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class RapunzelT(object):
class RapunzelT:

As above, Explicitly inheriting from object is redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant