Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: allow passing extra vmargs to jdt #251

Conversation

diasbruno
Copy link

@diasbruno diasbruno commented Apr 15, 2019

Hi,

This patch allow users to set more Java VM args (helpful if using lombok).

Example:

(setq eglot-eclipse-jdt-extra-vmargs
      (list "-noverify"
            "-Xmx1G"
            "-XX:+UseG1GC"
            "-XX:+UseStringDeduplication"
            "-javaagent:/path/to/lombok/lombok-1.18.6.jar"
            "-Xbootclasspath/a:/path/to/lombok/lombok-1.18.6.jar"))

@mkcms
Copy link
Collaborator

mkcms commented May 7, 2019

Thanks for the PR, however I think a better approach is to provide a way for users to subclass eglot-eclipse-jdt or modify the entry in eglot-server-programsrather than providing a customization variable. Do you want to try that instead?

We've already discussed this customization issue before, specifically for the Eclipse JDT server. @joaotavora decided not to provide server-specific customization variables, because eglot is minimalist by design.

@diasbruno
Copy link
Author

Thanks, @mkcms. No problem, I'll give it a try.

@skangas skangas changed the title Feature: allow passing extra vmargs to jdt. Feature: allow passing extra vmargs to jdt Jan 8, 2022
@skangas skangas added the WIP Work in progress label Jan 8, 2022
@skangas
Copy link
Collaborator

skangas commented Jan 8, 2022

@diasbruno Hi! Did you make any progress here?

@diasbruno
Copy link
Author

diasbruno commented Jan 8, 2022

Hi @skangas, I didn't have a chance to look this.

@joaotavora
Copy link
Owner

I think this was recently fixed by the changes described in annoucement #868. See also #911 for a success story.

@joaotavora joaotavora closed this Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants