Address feedback

src/download.js

@@ -1,7 +1,7 @@
 'use strict';
 
 var path = require('path');
-const { downloadArtifact } = require('@electron/get');
+const { downloadArtifact, getDownloadUrl } = require('@electron/get');
 var semver = require('semver');
 var rename = require('gulp-rename');
 var es = require('event-stream');
@@ -31,24 +31,38 @@ function download(opts, cb) {
 		version: opts.version,
 		platform: opts.platform,
 		arch,
-		artifactName: opts.assetName,
+		token: opts.token
 	};
 
-	(opts.repo ? getDownloadUrl(opts.repo, downloadOptions) : Promise.resolve({})).then(({
-		err, downloadURL
-	}) => {
-		if (err) return cb(err)
-
-		if (downloadURL) {
-			downloadOptions['mirrorOptions'] = { mirror: downloadUrl }
-		}
+	if (opts.repo) {
+		getDownloadUrl(opts.repo, downloadOptions)
+		.then(({err, downloadUrl, assetName}) => {
+			if (err) return cb(err)
+
+			downloadOptions['mirrorOptions'] = {
+				mirror: downloadUrl,
+				customFilename: assetName
+			};
 
+			downloadOptions['artifactName'] = assetName;
+			downloadOptions['unsafelyDisableChecksums'] = true;
+
+			downloadArtifact(downloadOptions).then(zipFilePath => {
+				return cb(null, zipFilePath)
+			}).catch(err => {
+				return cb(err); 
+			});
+		})
+		.catch(err => {
+			return cb(err); 
+		});
+	} else {
 		downloadArtifact(downloadOptions).then(zipFilePath => {
 			return cb(null, zipFilePath)
 		}).catch(err => {
 			return cb(err); 
 		});
-	});
+	}
 }
 
 function getDarwinLibFFMpegPath(opts) {

src/util.js

@@ -1,18 +1,19 @@
 'use strict';
 
 const { Octokit } = require('@octokit/rest');
+const got = require('got');
 
 function startsWith (haystack, needle) {
 	return haystack.substr(0, needle.length) === needle;
 };
 
-async function getDownloadUrl(repo, { version, platform, arch, token }) {
-	const [owner, repository] = repo.split('/');
-	const octokit = new Octokit({ auth: `token ${token}`});
+async function getDownloadUrl(repoUrl, { version, platform, arch, token }) {
+	const [owner, repo] = repoUrl.split('/');
+	const octokit = new Octokit({ auth: token });
 
 	const { data: release } = await octokit.repos.getReleaseByTag({
 		owner,
-		repository,
+		repo,
 		tag: version,
 	});
 
@@ -22,7 +23,7 @@ async function getDownloadUrl(repo, { version, platform, arch, token }) {
 
 	const { data: assets } = await octokit.repos.listAssetsForRelease({
 		owner,
-		repository,
+		repo,
 		release_id: release.id,
 	});
 
@@ -35,16 +36,25 @@ async function getDownloadUrl(repo, { version, platform, arch, token }) {
 		return { error: `Release asset for ${version} not found` }
 	}
 
-	const { headers: { location }} = await octokit.repos.getReleaseAsset({
+	const requestOptions = await octokit.repos.getReleaseAsset.endpoint({
 		owner,
-		repository,
+		repo,
 		asset_id: asset.id,
 		headers: {
-			accept: 'application/octet-stream'
+			Accept: 'application/octet-stream'
 		}
 	});
 
-	return { error: null, location };
+	const { url, headers } = requestOptions;
+	headers.authorization = `token ${token}`;
+
+	const response = await got(url, {
+		followRedirect: false,
+		method: 'HEAD',
+		headers
+	});
+
+	return { error: null, location: response.headers.location, assetName: asset.name };
 }
 
 module.exports = {