Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v74 #321

Merged
merged 5 commits into from
Feb 3, 2020
Merged

Release v74 #321

merged 5 commits into from
Feb 3, 2020

Conversation

guymcswain
Copy link
Collaborator

Joan, with your review and approval, V74 is ready to merge to the master branch. I plan to do this next week (Feb).

This release contains the following changes:

  1. Mea culpa, this change initializes the parameter for setsockopt() to enable address reuse. Issues Delay on reboot/shutdown #274 and restarting pigpiod result in "bind to port 8888 failed (Address already in use)" #298 are the targets of this change. I did not hear back from the authors of those issues but my own testing shows this to be an intermittent problem that is fixed.

  2. New hardware revision decode scheme addresses issues patch for pigpiod to work with 64bit gentoo #266 and Could not detect Raspberry Pi 3B+ on linux 4.19 64-bit #316. This change was tested by the authors of those issues and reported to work on 64-bit OS. My own testing found an issue with a legacy revision code and this was subsequently fixed. My testing covered all generations of raspberry pi except Pi4 (I don't own this hw, yet). Mostly for this reason, I'd like to keep this PR open until someone can verify on a Pi4. User level debug messages were added that will enable a quick verification of the failure signature should a user encounter a problem.

  3. A 'cherry-picked' commit from PR #223: Fix waveform length when merging pulses #225 that fixes issue Incorrect waveform length when using multiple invocations of "pigs wvag ..." #223. All tests pass.

guymcswain and others added 5 commits January 10, 2020 00:50
Decode hardware revision from either:
1) 'revision' string in /proc/cpuinfo (legacy)
2) binary number in /proc/device-tree/system/linux,revision

The second path is recommended by raspberrypi.org for newer
operating systems.  See raspberrypi/linux#2110
@guymcswain guymcswain requested a review from joan2937 January 26, 2020 04:24
@guymcswain
Copy link
Collaborator Author

Mostly for this reason, I'd like to keep this PR open until someone can verify on a Pi4.

Actually, 64-bit gentoo folks tested on both Pi3 and Pi4.

Copy link
Owner

@joan2937 joan2937 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kind of you to ask for my review but there is no need. You understand the changes made and needed far better than I do!

I must say I am very impressed with the amount of work you have got through in such a short time. Congratulations.

@guymcswain guymcswain merged commit bab05ce into master Feb 3, 2020
@guymcswain guymcswain deleted the Release-v74 branch February 3, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants