feat: added image crop option when selecting images (cocktail, ingredient, glass and garnish) #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
…orm validation not working correctly Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
1 task
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
…-add-image-crop-when-uploading-images # Conflicts: # package.json # pnpm-lock.yaml
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
…-add-image-crop-when-uploading-images # Conflicts: # components/cocktails/CocktailRecipeForm.tsx # pnpm-lock.yaml
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
jhns-de
approved these changes
Sep 11, 2024
jg-semantic-release-bot bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
# [1.9.0](v1.8.2...v1.9.0) (2024-09-11) ### Bug Fixes * Form validation and error message handling ([cdda452](cdda452)) * Routing when updating an cocktail from the search view ([a5abba8](a5abba8)) ### Features * added cocktail ratings ([#415](#415)) ([850646a](850646a)) * added image crop option when selecting images (cocktail, ingredient, glass and garnish) ([#413](#413)) ([d5ec542](d5ec542)) * Added name similarity check at ingredient-, cocktail-, garnish- and glassform ([#403](#403)) ([0183a0a](0183a0a)) * Added notes to cocktails, redesigned the cocktail info popup field, general popup behavior improved ([#402](#402)) ([a57aeee](a57aeee)) * Added offline availability with service workers ([#405](#405)) by [@Resaki1](https://github.com/resaki1) ([43798b3](43798b3)) * Added option to make cocktail ingredients and steps optional ([#404](#404)) ([83e7f8c](83e7f8c))
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing issues:
Before you mark this PR as ready, please check the following points
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
pnpm format:check, if invalidpnpm format:fix)pnpm build)Describe your work, what changed
To ensure the correct image aspect ration it is neccessary to crop them before upload. This issue resolves this wanted behavior by adding a crop option before every upload
Affected sites (please check during review):