Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: View settings dropdown on main page is now scrollable #362

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

jo-gross
Copy link
Owner

@jo-gross jo-gross commented Aug 10, 2024

Closing issues:

Before you mark this PR as ready, please check the following points

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I´e created all necessary migrations?
  • The format is correct (pnpm format:check, if invalid pnpm format:fix)
  • No build errors (pnpm build)
  • I´ve tested the implemented function by my own
  • Ensure the pr title fits the conventional commit standard

Describe your work, what changed

Made the dropdown scrollable when it´s getting larger than the screen.

Affected sites (please check during review):

  • [workspaceId]/index - Click on the eye and reduce your screen height, it should be displayed inside always

Signed-off-by: Johannes Groß <mail@gross-johannes.de>
@jo-gross jo-gross requested a review from jhns-de August 10, 2024 10:05
@jo-gross jo-gross linked an issue Aug 10, 2024 that may be closed by this pull request
1 task
@jo-gross jo-gross merged commit 3e2670c into main Aug 24, 2024
3 checks passed
@jo-gross jo-gross deleted the 358-bug-cards-not-selectable-when-larger-than-screen branch August 24, 2024 08:04
jg-semantic-release-bot bot pushed a commit that referenced this pull request Aug 24, 2024
# [1.8.0](v1.7.3...v1.8.0) (2024-08-24)

### Bug Fixes

* conalco ingredient import ([a4b5b41](a4b5b41))
* Fixed closing modal bug in chrome/-ium and safari and added stackable modals ([#352](#352)) ([ebba732](ebba732))
* Loading ui bug ([#349](#349)) ([be6a9ab](be6a9ab))
* manage xy made image expandable ([#366](#366)) ([a4b5dca](a4b5dca))
* mange xy head bar now sticky to the top ([#364](#364)) ([a7f0093](a7f0093))
* Mobile tag input not working on chrome ([#356](#356)) ([7e80948](7e80948))
* scroll to top on search page when cocktail gets selected ([#363](#363)) ([a883568](a883568))
* Small ui stuff at cocktail form (glass sorting, garnish opt label, ...) ([#380](#380)) ([3329c27](3329c27))
* user leave and remove buttons ([#365](#365)) ([3d67066](3d67066))
* View settings dropdown on main page is now scrollable ([#362](#362)) ([3e2670c](3e2670c))
* Wrong unit conversion after conalco import ([#336](#336)) ([d9a44f2](d9a44f2))

### Features

* 'new version' popup at workspace selection page after new release ([#372](#372)) ([6c47b29](6c47b29))
* Added cocktail description to cocktail card at search modal and search page ([#351](#351)) ([6f7f0c4](6f7f0c4))
* Added glass and garnish col to manage cocktail view ([#378](#378)) ([1fbf183](1fbf183))
* Archive cocktails and fix of the cocktail unsaved changes detection bug  ([#353](#353)) ([c3e8144](c3e8144))
* Custom ice ([#354](#354)) ([708a698](708a698))
@jg-semantic-release-bot
Copy link

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Cards not selectable when larger than screen
2 participants