fix: Fixed closing modal bug in chrome/-ium and safari and added stackable modals #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
1 task
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
jhns-de
approved these changes
Aug 24, 2024
jo-gross
deleted the
334-bug-modal-closes-when-removing-stuff-in-the-modal
branch
jg-semantic-release-bot bot
pushed a commit
that referenced
this pull request
Aug 24, 2024
# [1.8.0](v1.7.3...v1.8.0) (2024-08-24) ### Bug Fixes * conalco ingredient import ([a4b5b41](a4b5b41)) * Fixed closing modal bug in chrome/-ium and safari and added stackable modals ([#352](#352)) ([ebba732](ebba732)) * Loading ui bug ([#349](#349)) ([be6a9ab](be6a9ab)) * manage xy made image expandable ([#366](#366)) ([a4b5dca](a4b5dca)) * mange xy head bar now sticky to the top ([#364](#364)) ([a7f0093](a7f0093)) * Mobile tag input not working on chrome ([#356](#356)) ([7e80948](7e80948)) * scroll to top on search page when cocktail gets selected ([#363](#363)) ([a883568](a883568)) * Small ui stuff at cocktail form (glass sorting, garnish opt label, ...) ([#380](#380)) ([3329c27](3329c27)) * user leave and remove buttons ([#365](#365)) ([3d67066](3d67066)) * View settings dropdown on main page is now scrollable ([#362](#362)) ([3e2670c](3e2670c)) * Wrong unit conversion after conalco import ([#336](#336)) ([d9a44f2](d9a44f2)) ### Features * 'new version' popup at workspace selection page after new release ([#372](#372)) ([6c47b29](6c47b29)) * Added cocktail description to cocktail card at search modal and search page ([#351](#351)) ([6f7f0c4](6f7f0c4)) * Added glass and garnish col to manage cocktail view ([#378](#378)) ([1fbf183](1fbf183)) * Archive cocktails and fix of the cocktail unsaved changes detection bug ([#353](#353)) ([c3e8144](c3e8144)) * Custom ice ([#354](#354)) ([708a698](708a698))
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing issues:
Before you mark this PR as ready, please check the following points
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
pnpm format:check, if invalidpnpm format:fix)pnpm build)Describe your work, what changed
Changed the modal method from checkbox (depr.) to the latest way to dialog tags. This resolves the issue, that the modal closes when hitting the backpane of the modal.
Added addititionally an modal stack. This prevents the modal from closing when opening another modal from within.