Do not overwrite default headers unless specified #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, calling `HTTParty.headers` just to access them set
`HTTParty.default_options[:headers]` to an empty hash. Now they will
only be set to an empty hash when one is explicitly provided, otherwise
they will remain `nil`.
The previous behavior was problematic because the default headers
for a request could either be `nil` or `{}`, depending on whether
`HTTParty.headers` had been called. When they are `nil` the
default headers from Net::HTTP are used.
|
Thanks @jnunemaker! 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, calling
HTTParty.headerswithout an argument setHTTParty.default_options[:headers]to an empty hash. Now thedefault headers will only be set to an empty hash when one is
explicitly provided, otherwise they will remain
nil.The previous behavior was problematic because the default headers
for a request could either be
nilor{}, depending on whetherHTTParty.headershad been called. When they arenilthedefault headers from Net::HTTP are used.
@jnunemaker any feedback is appreciated! This feels to me like a bit more of a workaround than a real solution, but I don't see a cleaner solution without a somewhat larger refactor.
Thanks to @tomatoturnip for the original PR.