Do not pass proxy options to Net::HTTP connection if not specified #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 2.0 has changed the Net::HTTP.new method so that if you don't specify a proxy address it defaults to using the proxy specified by the http_proxy environment variable (if set). Passing nil for the proxy address now means that a proxy is never used even if the http_proxy environment variable is set. However HTTParty was always passing the proxy option values even if they were nil, which meant that the defaulting to http_proxy environment variable didn't work. With this change the proxy values are only passed if http_proxyaddr is non-nil.
jnunemaker
pushed a commit
that referenced
this pull request
Jul 16, 2013
Do not pass proxy options to Net::HTTP connection if not specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.0 has changed the Net::HTTP.new method so that if you don't specify
a proxy address it defaults to using the proxy specified by the http_proxy
environment variable (if set). Passing nil for the proxy address now means
that a proxy is never used even if the http_proxy environment variable is
set.
However HTTParty was always passing the proxy option values even if they
were nil, which meant that the defaulting to http_proxy environment variable
didn't work.
With this change the proxy values are only passed if http_proxyaddr is non-nil.
See issue #184 for further details.