Replace multi_json with stdlib json #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of June 2013, multi_json will no longer be maintained.
|
Why make the latest json gem a dependency? Is it the same json as what is in stdlib? I haven't followed all the json changes of late so I'm curious. |
|
@jnunemaker it is my understanding that it will either use the stdlib json, or the latest json gem, if available. But maybe I'm not understanding that correctly. You think we are better off removing that dependency and leaving it up to the ruby environment? |
|
@jnunemaker any further thoughts on this? I can remove the dependency, if that's the only thing holding it up. |
jnunemaker
pushed a commit
that referenced
this pull request
Jun 24, 2013
Replace multi_json with stdlib json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 1.9 standard library includes
json, andmulti_jsonwill no longer be maintained as of June. This aligns with planned stoppage on ruby 1.8.7.This patch should also improve JSON parsing performance, and make life more better!