Autoconf tweaks #265
Merged
Autoconf tweaks #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config options used by autoconf have type hints, but turns out the type checks are run as config-inited events with a priority of 800. The default priority is 500, making autoconf run before type checks. This means having wrong type config settings in conf.py might throw a backtrace from _autoconf before any warnings about it. It can be as simple as setting hawkmoth_autoconf = None, leading to TypeError: 'NoneType' object is not iterable. Use a priority of 850 for autoconf to delay it until after type checks. This won't avoid any backtraces, but we'll get the warning first, making the problem easier for the user to fix: WARNING: The config value `hawkmoth_autoconf' has type `NoneType'; expected `list'.
Similar to hawkmoth_compiler. Seems slightly more natural than having to set to [] to disable.
Indicate where None is allowed and that the lists are lists of strings. (Though the Sphinx type checker does not seem to enforce this.)
It can be difficult to debug issues with header search path. Debug log the discovered include arguments for each language.
Document the default value of ['stdinc'] and describe how to disable autoconf. Drop the same from hawkmoth_compiler, as it's not quite accurate. Setting hawkmoth_compiler to None leads to WARNING: autoconf: 'stdinc' option ignored (missing compiler).
|
Shiny. Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I toyed with the new autoconf stuff and ran into some small issues. Fix and tweak it a bit.