Add Gherkin abstraction layer #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing direct `cucumber-gherkin` access with `cuke_modeler` usage.
Updated a few more likely looking spots, even though no tests failed without the changes.
Using the latest release of `cuke_modeler` in order to have cleaner access to node column and line data.
Using the latest release of `cuke_modeler` in order to have cleaner access to feature language data.
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw #243 and just couldn't help myself.
It's a a larger change than just updating to the newest version of
cucumber-gherkinbecause the idea is to no longer be tied to it so directly and go through cuke_modeler instead because it's more stable. I didn't want to change too much, though, so I left all of the Turnip node classes instead of replacing them entirely with CukeModeler equivalents.