Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map support in addition to the current CompositeData #148

Merged
merged 4 commits into from
May 5, 2020
Merged

Map support in addition to the current CompositeData #148

merged 4 commits into from
May 5, 2020

Conversation

ggrandes
Copy link
Contributor

@ggrandes ggrandes commented May 4, 2020

Support for a basic type easier and lighter to implement in applications than CompositeData.
Tested on OpenJDK 1.7.0_201

@cyrille-leclerc cyrille-leclerc merged commit 12789e6 into jmxtrans:master May 5, 2020
@ggrandes
Copy link
Contributor Author

Thanks @cyrille-leclerc !

@cyrille-leclerc
Copy link
Member

I get the following findbugs exception when building, I'm looking at this problem to release.

[INFO] org.jmxtrans.agent.Query.collectAndExportAttribute(MBeanServer, OutputWriter, ObjectName, String) makes inefficient use of keySet iterator instead of entrySet iterator [org.jmxtrans.agent.Query] At Query.java:[line 227] WMI_WRONG_MAP_ITERATOR

cyrille-leclerc added a commit that referenced this pull request May 11, 2020
@ggrandes
Copy link
Contributor Author

Well, I copied the construct of "if (attributeValue instanceof CompositeData)" in "if (attributeValue instanceof Map)" maintaining the same code-style, but entrySet is more efficient of course.
Thanks for the feedback.

@cyrille-leclerc
Copy link
Member

Shipped in 1.2.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants