Make ext events private

jmonster · Mar 12, 2013 · d38c2e2 · d38c2e2
1 parent cc13017
commit d38c2e2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/lib/ext.js b/lib/ext.js
@@ -16,9 +16,11 @@ var internals = {};
 
 module.exports = internals.Ext = function () {
 
-    this.onRequest = null;                              // New request, before handing over to the router (allows changes to the request method, url, etc.)
-    this.onPreHandler = null;                           // After validation and body parsing, before route handler
-    this.onPostHandler = null;                          // After route handler returns, before sending response
+    this._events = {
+        onRequest: null,                            // New request, before handing over to the router (allows changes to the request method, url, etc.)
+        onPreHandler: null,                         // After validation and body parsing, before route handler
+        onPostHandler: null                         // After route handler returns, before sending response
+    };
 };
 
 
@@ -34,10 +36,10 @@ internals.Ext.prototype._add = function (event, func, options, plugin) {
 
     Utils.assert(['onRequest', 'onPreHandler', 'onPostHandler'].indexOf(event) !== -1, 'Unknown event type: ' + event);
 
-    this[event] = this[event] || []
+    this._events[event] = this._events[event] || []
 
     var ext = {
-        priority: this[event].length,
+        priority: this._events[event].length,
         before: Utils.clone(options.before) || [],
         after: Utils.clone(options.after) || [],
         group: plugin || '?',
@@ -53,14 +55,14 @@ internals.Ext.prototype._add = function (event, func, options, plugin) {
 
     // Insert event
 
-    this[event].push(ext);
+    this._events[event].push(ext);
     this.sort(event);
 };
 
 
 internals.Ext.prototype.sort = function (event) {
 
-    var input = this[event];
+    var input = this._events[event];
     if (!input) {
         return;
     }
@@ -71,13 +73,13 @@ internals.Ext.prototype.sort = function (event) {
 
     // Apply
 
-    this[event] = sorted;
+    this._events[event] = sorted;
 };
 
 
 internals.Ext.prototype.invoke = function (request, event, callback) {
 
-    var handlers = this[event];            // onRequest, onPreHandler, onPostHandler
+    var handlers = this._events[event];            // onRequest, onPreHandler, onPostHandler
     if (!handlers) {
         return callback();
     }

diff --git a/test/unit/ext.js b/test/unit/ext.js
@@ -27,7 +27,7 @@ describe('Ext', function () {
 
             var ext = new Ext();
             ext.sort('onRequest');
-            expect(ext.onRequest).to.equal(null);
+            expect(ext._events.onRequest).to.equal(null);
             done();
         });
     });