Remove adding error tag. Closes hapijs#1231

jmonster · Dec 20, 2013 · 6f860d5 · 6f860d5
1 parent 2033802
commit 6f860d5
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/lib/ext.js b/lib/ext.js
@@ -134,7 +134,7 @@ internals.Ext.runProtected = function (logger, tags, next, setup) {        // se
     var onError = function (err) {
 
         if (logger) {
-            logger.log(['hapi', 'uncaught'].concat(tags || []), err);                  // 'uncaught' treated special in request.log
+            logger.log(['hapi', 'uncaught', 'error'].concat(tags || []), err);                  // 'uncaught' treated special in request.log
         }
 
         return finish(Boom.badImplementation('Uncaught error', err));

diff --git a/lib/request.js b/lib/request.js
@@ -210,8 +210,6 @@ internals.Request.prototype.log = function (tags, data, timestamp) {
 
     if (data) {
         if (data instanceof Error) {
-            item.tags = tags.concat('error');
-            tagsMap.error = true;
             item.data = (data.isBoom ? data.decorations() : {});
             item.data.message = data.message;
             if (tagsMap.uncaught) {

diff --git a/test/integration/request.js b/test/integration/request.js
@@ -292,7 +292,7 @@ describe('Request', function () {
 
             if (prints === 1) {
                 expect(arguments[0]).to.equal('Debug:');
-                expect(arguments[1]).to.equal('hapi, uncaught, handler, error');
+                expect(arguments[1]).to.equal('hapi, uncaught, error, handler');
             }
             else {
                 console.error = orig;