Add explicit setuptools dependency for pkg_resources #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the package uses pkg_resources, add an explicit install_requires for setuptools. While it is not technically required to install it right now, it is going to help distribution packagers notice the necessity of using a runtime dependency (vs the usual build-time dependency).
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 556 556
=========================================
Hits 556 556
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Sounds reasonable, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the package uses pkg_resources, add an explicit install_requires
for setuptools. While it is not technically required to install it
right now, it is going to help distribution packagers notice
the necessity of using a runtime dependency (vs the usual build-time
dependency).