fix ControlLogix readTag call and fix call to readInt32LE #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmmoser
approved these changes
Oct 31, 2017
|
@jmmoser the review looks good. Thanks for merging! |
|
Jake, shoot me an email at jmmoser15@gmail.com if you have questions about anything in this repository. A lot of it hasn't been tied together yet.. Modbus over CIP, CIP over PCCC, many many functions like WriteTagFragmented, uploading/downloading PLC configurations, etc. Assume none of it is tested. I do use the appropriate read/write functions for CIP, PCCC, ModbusTCP for interacting with our production machines. Very excited about my first star! |
|
@jmmoser cool! I figured this project was still a WIP so thats all good with me. I should be able to make some more PRs as try out the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.