bug fix, and add account_number (for IRA account) #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mw66
changed the title
mw66
commented
Jun 5, 2023
| if not data: | ||
| data= { | ||
| 'adjusted_mark_price':'', | ||
| 'ask_price':'', |
There was a problem hiding this comment.
e.g it makes no sense to check if data['ask_price'] is empty in the caller, and all other dict keys; instead the caller should just check if data is None.
This was referenced Aug 10, 2023
Does pyrh support multiple (IRA) accounts trading as robin_stocks doe?
robinhood-unofficial/pyrh#312
Closed
|
Is there any update on this? |
|
merged: Jun 16, 2023 |
is there any way to get the traded history and daily portfolio value of an IRA account? The 2 functions below for these 2 tasks only do it for the regular individual account by default and do not allow to specify account number. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- add check if instrument is None in get_option_market_data_by_id()
-- add account_number to get_all_open_option_orders()
-- add account_number to option_orders_url()