Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The desired step size for setting the target temperature #311

Closed
ckellerdk opened this issue Jan 4, 2024 · 5 comments
Closed

The desired step size for setting the target temperature #311

ckellerdk opened this issue Jan 4, 2024 · 5 comments
Labels
developed When development is done and tested enhancement New feature or request P1 Priority 1

Comments

@ckellerdk
Copy link

Hi
I would like an option to change the step size of the desired temperature.

Would this be an option?

@HACS-bank
Copy link

HACS-bank commented Jan 4, 2024 via email

@jmcollin78
Copy link
Owner

If someone is ready to do a PR of this subject I will be glad to merge it. It is something easy to do, and I can help if needed.
I'm on more important subjects for now.

@jmcollin78 jmcollin78 added the enhancement New feature or request label Jan 4, 2024
@giopeco
Copy link

giopeco commented Jan 20, 2024

I will also add to the request! beer offer guaranteed!
thanks for the great work!

@giopeco
Copy link

giopeco commented Jan 20, 2024

for the time being, is it possible to manually modify some parameter to bring target_temp_step to 0.5?

@jmcollin78 jmcollin78 added the P1 Priority 1 label Jan 20, 2024
@jmcollin78 jmcollin78 added the developed When development is done and tested label Jan 21, 2024
jmcollin78 added a commit that referenced this issue Jan 21, 2024
* Add step temperature in config

* All testus ok

* Keep the step of the VTherm and not the step of the underlying

* Release 5.4.0

---------

Co-authored-by: Jean-Marc Collin <jean-marc.collin-extern@renault.com>
@jmcollin78
Copy link
Owner

@giopeco so many thanks for the beer ! You rocks

The update is available on the main branch if you don't want to wait the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developed When development is done and tested enhancement New feature or request P1 Priority 1
Projects
None yet
Development

No branches or pull requests

4 participants