Bump eyre to a version without a security advisory #155
clippy
25 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 25 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.80.0-nightly (c987ad527 2024-05-01)
- cargo 1.80.0-nightly (6087566b3 2024-04-30)
- clippy 0.1.79 (c987ad5 2024-05-01)
Annotations
Check warning on line 26 in day8/src/main.rs
github-actions / clippy
`flatten()` will run forever if the iterator repeatedly produces an `Err`
warning: `flatten()` will run forever if the iterator repeatedly produces an `Err`
--> day8/src/main.rs:26:63
|
26 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^ help: replace with: `map_while(Result::ok)`
|
note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error
--> day8/src/main.rs:26:30
|
26 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
= note: `#[warn(clippy::lines_filter_map_ok)]` on by default
Check warning on line 41 in day6/src/main.rs
github-actions / clippy
`flatten()` will run forever if the iterator repeatedly produces an `Err`
warning: `flatten()` will run forever if the iterator repeatedly produces an `Err`
--> day6/src/main.rs:41:63
|
41 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^ help: replace with: `map_while(Result::ok)`
|
note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error
--> day6/src/main.rs:41:30
|
41 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
= note: `#[warn(clippy::lines_filter_map_ok)]` on by default
Check warning on line 91 in day23/src/main.rs
github-actions / clippy
writing `&Vec` instead of `&[_]` involves a new object where a slice will do
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> day23/src/main.rs:91:22
|
91 | fn run(instructions: &Vec<Instruction>, regs: &mut [u64; 2]) -> Result<()> {
| ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
Check warning on line 37 in day23/src/main.rs
github-actions / clippy
`flatten()` will run forever if the iterator repeatedly produces an `Err`
warning: `flatten()` will run forever if the iterator repeatedly produces an `Err`
--> day23/src/main.rs:37:63
|
37 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^ help: replace with: `map_while(Result::ok)`
|
note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error
--> day23/src/main.rs:37:30
|
37 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
= note: `#[warn(clippy::lines_filter_map_ok)]` on by default
Check warning on line 27 in day17/src/main.rs
github-actions / clippy
`flatten()` will run forever if the iterator repeatedly produces an `Err`
warning: `flatten()` will run forever if the iterator repeatedly produces an `Err`
--> day17/src/main.rs:27:63
|
27 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^ help: replace with: `map_while(Result::ok)`
|
note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error
--> day17/src/main.rs:27:30
|
27 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
= note: `#[warn(clippy::lines_filter_map_ok)]` on by default
Check warning on line 26 in day24/src/main.rs
github-actions / clippy
`flatten()` will run forever if the iterator repeatedly produces an `Err`
warning: `flatten()` will run forever if the iterator repeatedly produces an `Err`
--> day24/src/main.rs:26:63
|
26 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^ help: replace with: `map_while(Result::ok)`
|
note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error
--> day24/src/main.rs:26:30
|
26 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
= note: `#[warn(clippy::lines_filter_map_ok)]` on by default
Check warning on line 22 in day1/src/main.rs
github-actions / clippy
`flatten()` will run forever if the iterator repeatedly produces an `Err`
warning: `flatten()` will run forever if the iterator repeatedly produces an `Err`
--> day1/src/main.rs:22:63
|
22 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^ help: replace with: `map_while(Result::ok)`
|
note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error
--> day1/src/main.rs:22:30
|
22 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
= note: `#[warn(clippy::lines_filter_map_ok)]` on by default
Check warning on line 26 in day5/src/main.rs
github-actions / clippy
`flatten()` will run forever if the iterator repeatedly produces an `Err`
warning: `flatten()` will run forever if the iterator repeatedly produces an `Err`
--> day5/src/main.rs:26:63
|
26 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^ help: replace with: `map_while(Result::ok)`
|
note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error
--> day5/src/main.rs:26:30
|
26 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
= note: `#[warn(clippy::lines_filter_map_ok)]` on by default
Check warning on line 22 in day2/src/main.rs
github-actions / clippy
`flatten()` will run forever if the iterator repeatedly produces an `Err`
warning: `flatten()` will run forever if the iterator repeatedly produces an `Err`
--> day2/src/main.rs:22:63
|
22 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^ help: replace with: `map_while(Result::ok)`
|
note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error
--> day2/src/main.rs:22:30
|
22 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
= note: `#[warn(clippy::lines_filter_map_ok)]` on by default
Check warning on line 22 in day4/src/main.rs
github-actions / clippy
`flatten()` will run forever if the iterator repeatedly produces an `Err`
warning: `flatten()` will run forever if the iterator repeatedly produces an `Err`
--> day4/src/main.rs:22:63
|
22 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^ help: replace with: `map_while(Result::ok)`
|
note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error
--> day4/src/main.rs:22:30
|
22 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
= note: `#[warn(clippy::lines_filter_map_ok)]` on by default
Check warning on line 26 in day3/src/main.rs
github-actions / clippy
`flatten()` will run forever if the iterator repeatedly produces an `Err`
warning: `flatten()` will run forever if the iterator repeatedly produces an `Err`
--> day3/src/main.rs:26:63
|
26 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^ help: replace with: `map_while(Result::ok)`
|
note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error
--> day3/src/main.rs:26:30
|
26 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
= note: `#[warn(clippy::lines_filter_map_ok)]` on by default
Check warning on line 131 in day19/src/main.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> day19/src/main.rs:131:17
|
131 | test = t.clone();
| ^^^^^^^^^^^^^^^^ help: use `clone_from()`: `test.clone_from(t)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
Check warning on line 28 in day19/src/main.rs
github-actions / clippy
`flatten()` will run forever if the iterator repeatedly produces an `Err`
warning: `flatten()` will run forever if the iterator repeatedly produces an `Err`
--> day19/src/main.rs:28:63
|
28 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^ help: replace with: `map_while(Result::ok)`
|
note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error
--> day19/src/main.rs:28:30
|
28 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
= note: `#[warn(clippy::lines_filter_map_ok)]` on by default
Check warning on line 36 in day14/src/main.rs
github-actions / clippy
`flatten()` will run forever if the iterator repeatedly produces an `Err`
warning: `flatten()` will run forever if the iterator repeatedly produces an `Err`
--> day14/src/main.rs:36:63
|
36 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^ help: replace with: `map_while(Result::ok)`
|
note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error
--> day14/src/main.rs:36:30
|
36 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
= note: `#[warn(clippy::lines_filter_map_ok)]` on by default
Check warning on line 38 in day16/src/main.rs
github-actions / clippy
`flatten()` will run forever if the iterator repeatedly produces an `Err`
warning: `flatten()` will run forever if the iterator repeatedly produces an `Err`
--> day16/src/main.rs:38:63
|
38 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^ help: replace with: `map_while(Result::ok)`
|
note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error
--> day16/src/main.rs:38:30
|
38 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
= note: `#[warn(clippy::lines_filter_map_ok)]` on by default
Check warning on line 37 in day18/src/main.rs
github-actions / clippy
`flatten()` will run forever if the iterator repeatedly produces an `Err`
warning: `flatten()` will run forever if the iterator repeatedly produces an `Err`
--> day18/src/main.rs:37:63
|
37 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^ help: replace with: `map_while(Result::ok)`
|
note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error
--> day18/src/main.rs:37:30
|
37 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
= note: `#[warn(clippy::lines_filter_map_ok)]` on by default
Check warning on line 27 in day9/src/main.rs
github-actions / clippy
`flatten()` will run forever if the iterator repeatedly produces an `Err`
warning: `flatten()` will run forever if the iterator repeatedly produces an `Err`
--> day9/src/main.rs:27:63
|
27 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^ help: replace with: `map_while(Result::ok)`
|
note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error
--> day9/src/main.rs:27:30
|
27 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
= note: `#[warn(clippy::lines_filter_map_ok)]` on by default
Check warning on line 147 in day7/src/main.rs
github-actions / clippy
writing `&Vec` instead of `&[_]` involves a new object where a slice will do
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> day7/src/main.rs:147:12
|
147 | parts: &Vec<&str>,
| ^^^^^^^^^^ help: change this to: `&[&str]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
Check warning on line 92 in day7/src/main.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> day7/src/main.rs:92:13
|
92 | vals = vals2.clone();
| ^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `vals.clone_from(&vals2)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
Check warning on line 91 in day7/src/main.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> day7/src/main.rs:91:13
|
91 | hm = hm2.clone();
| ^^^^^^^^^^^^^^^^ help: use `clone_from()`: `hm.clone_from(&hm2)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
Check warning on line 49 in day7/src/main.rs
github-actions / clippy
`flatten()` will run forever if the iterator repeatedly produces an `Err`
warning: `flatten()` will run forever if the iterator repeatedly produces an `Err`
--> day7/src/main.rs:49:63
|
49 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^ help: replace with: `map_while(Result::ok)`
|
note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error
--> day7/src/main.rs:49:30
|
49 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
= note: `#[warn(clippy::lines_filter_map_ok)]` on by default
Check warning on line 25 in day12/src/main.rs
github-actions / clippy
`flatten()` will run forever if the iterator repeatedly produces an `Err`
warning: `flatten()` will run forever if the iterator repeatedly produces an `Err`
--> day12/src/main.rs:25:63
|
25 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^ help: replace with: `map_while(Result::ok)`
|
note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error
--> day12/src/main.rs:25:30
|
25 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
= note: `#[warn(clippy::lines_filter_map_ok)]` on by default
Check warning on line 91 in day13/src/main.rs
github-actions / clippy
writing `&Vec` instead of `&[_]` involves a new object where a slice will do
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> day13/src/main.rs:91:72
|
91 | fn compute_happiness(happy: &HashMap<&str, HashMap<&str, i64>>, table: &Vec<&str>) -> i64 {
| ^^^^^^^^^^ help: change this to: `&[&str]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
Check warning on line 27 in day13/src/main.rs
github-actions / clippy
`flatten()` will run forever if the iterator repeatedly produces an `Err`
warning: `flatten()` will run forever if the iterator repeatedly produces an `Err`
--> day13/src/main.rs:27:63
|
27 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^ help: replace with: `map_while(Result::ok)`
|
note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error
--> day13/src/main.rs:27:30
|
27 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
= note: `#[warn(clippy::lines_filter_map_ok)]` on by default
Check warning on line 36 in day15/src/main.rs
github-actions / clippy
`flatten()` will run forever if the iterator repeatedly produces an `Err`
warning: `flatten()` will run forever if the iterator repeatedly produces an `Err`
--> day15/src/main.rs:36:63
|
36 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^ help: replace with: `map_while(Result::ok)`
|
note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error
--> day15/src/main.rs:36:30
|
36 | let lines: Vec<String> = io::BufReader::new(file).lines().flatten().collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok
= note: `#[warn(clippy::lines_filter_map_ok)]` on by default