Support duplicate timestamps by merging into single timestamp #1179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
I've noticed that ytdl-sub throws an error when duplicate timestamps are found in its check for ascending order. Makes total sense for albums where you only have one track at a time, but I've found user-submitted timestamps for DJ sets sometimes feature these. For example, the top timestamp comment under this video.
This pull request adds support for these duplicate timestamps by combining them into one with a delimiter in the timestamp title to split them up. I can change the delimiter if preferred, but it seemed like a good obvious one.
To find duplicates, I added a comparison to the last added Timestamp. If they match, the last added title is appended with the delimiter and the duplicate timestamp title. The duplicate's Timestamp object is ignored so only a single Chapter is created for that timecode.
Hoping we can get this implemented! Thanks!