Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix secure HTTP communication #14

Merged
merged 1 commit into from
Mar 18, 2018
Merged

Fix secure HTTP communication #14

merged 1 commit into from
Mar 18, 2018

Conversation

mjg59
Copy link
Contributor

@mjg59 mjg59 commented Mar 17, 2018

We need to send \r\n as a separator, not \n

@mjg59
Fix secure HTTP communication
8837206 
We need to send \r\n as a separator, not \n
@mjg59 mjg59 mentioned this pull request Mar 17, 2018
Closed
@jlusiardi
Copy link
Owner

Indeed the rfc says CRLF :)

@jlusiardi jlusiardi merged commit 506b835 into jlusiardi:master Mar 18, 2018
@mjg59
Copy link
Contributor Author

mjg59 commented Mar 18, 2018

Thanks! Any chance you can push a new release to Pypi? I'm finishing up support for Homekit devices in Home Assistant.

@jlusiardi
Copy link
Owner

Ok, can u give it a try with pypi? version 0.5 should be there.

@mjg59
Copy link
Contributor Author

mjg59 commented Mar 19, 2018

Perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjg59 @jlusiardi