refactor to reduce size of if statement

jloleysens · Jun 16, 2021 · 01434af · 01434af
1 parent 65c0390
commit 01434af
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/x-pack/plugins/fleet/public/search_provider.ts b/x-pack/plugins/fleet/public/search_provider.ts
@@ -23,6 +23,17 @@ import { pagePathGetters } from './constants';
 
 const packageType = 'package';
 
+const createPackages$ = () =>
+  from(sendGetPackages()).pipe(
+    map(({ error, data }) => {
+      if (error) {
+        throw error;
+      }
+      return data?.response ?? [];
+    }),
+    shareReplay(1)
+  );
+
 export const createPackageSearchProvider = (core: CoreSetup): GlobalSearchResultProvider => {
   const coreStart$ = from(core.getStartServices()).pipe(
     map(([coreStart]) => coreStart),
@@ -33,15 +44,7 @@ export const createPackageSearchProvider = (core: CoreSetup): GlobalSearchResult
 
   const getPackages$ = () => {
     if (!packages$) {
-      packages$ = from(sendGetPackages()).pipe(
-        map(({ error, data }) => {
-          if (error) {
-            throw error;
-          }
-          return data?.response ?? [];
-        }),
-        shareReplay(1)
-      );
+      packages$ = createPackages$();
     }
     return packages$;
   };