forked from twisted/klein
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Prefer unittest.mock but require mock for python < 3.3.
The unit tests require mock but don't specify it, which causes problems for any usages outside tox (e.g. testing that changes to twisted don't break klein). Use PEP508 to specify environment markers and only install mock when required. Tests can then conditionally import unittest.mock and fall back to mock. The conditional imports do raise a mypy error, discussed here: python/mypy#1153 So an annotation is required to silence this specific warning.
- Loading branch information
1 parent
61c0661
commit adc6341
Showing
3 changed files
with
9 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
mock ; python_version <= '3.3' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters